From abbe5be3eb4a86fd0ad5f13f645c813ee544dc80 Mon Sep 17 00:00:00 2001 From: Ivan Dyachkov Date: Thu, 16 Mar 2023 09:24:50 +0100 Subject: [PATCH] chore: use single default pr template --- .github/PULL_REQUEST_TEMPLATE/ci.md | 7 ------- .github/PULL_REQUEST_TEMPLATE/doc.md | 1 - .github/PULL_REQUEST_TEMPLATE/v4.md | 12 ------------ .../v5.md => pull_request_template.md} | 5 +++++ 4 files changed, 5 insertions(+), 20 deletions(-) delete mode 100644 .github/PULL_REQUEST_TEMPLATE/ci.md delete mode 100644 .github/PULL_REQUEST_TEMPLATE/doc.md delete mode 100644 .github/PULL_REQUEST_TEMPLATE/v4.md rename .github/{PULL_REQUEST_TEMPLATE/v5.md => pull_request_template.md} (68%) diff --git a/.github/PULL_REQUEST_TEMPLATE/ci.md b/.github/PULL_REQUEST_TEMPLATE/ci.md deleted file mode 100644 index 764933516..000000000 --- a/.github/PULL_REQUEST_TEMPLATE/ci.md +++ /dev/null @@ -1,7 +0,0 @@ -Fixes - -## PR Checklist -Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked: - -- [ ] If changed package build ci, pass [this action](https://github.com/emqx/emqx/actions/workflows/build_packages.yaml) (manual trigger) -- [ ] Change log has been added to `changes/` dir for user-facing artifacts update diff --git a/.github/PULL_REQUEST_TEMPLATE/doc.md b/.github/PULL_REQUEST_TEMPLATE/doc.md deleted file mode 100644 index af1c9127f..000000000 --- a/.github/PULL_REQUEST_TEMPLATE/doc.md +++ /dev/null @@ -1 +0,0 @@ -Fixes diff --git a/.github/PULL_REQUEST_TEMPLATE/v4.md b/.github/PULL_REQUEST_TEMPLATE/v4.md deleted file mode 100644 index 11b282091..000000000 --- a/.github/PULL_REQUEST_TEMPLATE/v4.md +++ /dev/null @@ -1,12 +0,0 @@ -Fixes - -## PR Checklist -Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked: - -- [ ] Added tests for the changes -- [ ] Changed lines covered in coverage report -- [ ] Change log has been added to `changes/` dir -- [ ] `appup` files updated (execute `scripts/update-appup.sh emqx`) -- [ ] For internal contributor: there is a jira ticket to track this change -- [ ] If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up -- [ ] In case of non-backward compatible changes, reviewer should check this item as a write-off, and add details in **Backward Compatibility** section diff --git a/.github/PULL_REQUEST_TEMPLATE/v5.md b/.github/pull_request_template.md similarity index 68% rename from .github/PULL_REQUEST_TEMPLATE/v5.md rename to .github/pull_request_template.md index 7952c1371..9b96db554 100644 --- a/.github/PULL_REQUEST_TEMPLATE/v5.md +++ b/.github/pull_request_template.md @@ -9,3 +9,8 @@ Please convert it to a draft if any of the following conditions are not met. Rev - [ ] For internal contributor: there is a jira ticket to track this change - [ ] If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up - [ ] Schema changes are backward compatible + +## Checklist for CI (.github/workflows) changes + +- [ ] If changed package build workflow, pass [this action](https://github.com/emqx/emqx/actions/workflows/build_packages.yaml) (manual trigger) +- [ ] Change log has been added to `changes/` dir for user-facing artifacts update