From 15041649339658f5eb67e0d45664470645b975f7 Mon Sep 17 00:00:00 2001 From: z8674558 Date: Tue, 2 Mar 2021 15:31:04 +0900 Subject: [PATCH] chore(src): fix dialyzer warnings (match values) --- apps/emqx_lwm2m/src/emqx_lwm2m_protocol.erl | 2 +- apps/emqx_management/src/emqx_mgmt_api_pubsub.erl | 2 +- apps/emqx_management/src/emqx_mgmt_data_backup.erl | 4 ++-- apps/emqx_rule_engine/src/emqx_rule_registry.erl | 4 ++-- apps/emqx_web_hook/src/emqx_web_hook_app.erl | 2 +- lib-ce/emqx_modules/src/emqx_modules_app.erl | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/apps/emqx_lwm2m/src/emqx_lwm2m_protocol.erl b/apps/emqx_lwm2m/src/emqx_lwm2m_protocol.erl index 45023783b..0a40d3765 100644 --- a/apps/emqx_lwm2m/src/emqx_lwm2m_protocol.erl +++ b/apps/emqx_lwm2m/src/emqx_lwm2m_protocol.erl @@ -121,7 +121,7 @@ update_reg_info(NewRegInfo, Lwm2mState = #lwm2m_state{ UpdatedRegInfo = maps:merge(RegInfo, NewRegInfo), - case proplists:get_value(update_msg_publish_condition, + _ = case proplists:get_value(update_msg_publish_condition, lwm2m_coap_responder:options(), contains_object_list) of always -> send_to_broker(<<"update">>, #{<<"data">> => UpdatedRegInfo}, Lwm2mState); diff --git a/apps/emqx_management/src/emqx_mgmt_api_pubsub.erl b/apps/emqx_management/src/emqx_mgmt_api_pubsub.erl index f49aecb0e..3b7f7392f 100644 --- a/apps/emqx_management/src/emqx_mgmt_api_pubsub.erl +++ b/apps/emqx_management/src/emqx_mgmt_api_pubsub.erl @@ -167,7 +167,7 @@ do_publish(_ClientId, [], _Qos, _Retain, _Payload) -> do_publish(ClientId, Topics, Qos, Retain, Payload) -> MsgIds = lists:map(fun(Topic) -> Msg = emqx_message:make(ClientId, Qos, Topic, Payload), - emqx_mgmt:publish(Msg#message{flags = #{retain => Retain}}), + _ = emqx_mgmt:publish(Msg#message{flags = #{retain => Retain}}), emqx_guid:to_hexstr(Msg#message.id) end, Topics), {ok, MsgIds}. diff --git a/apps/emqx_management/src/emqx_mgmt_data_backup.erl b/apps/emqx_management/src/emqx_mgmt_data_backup.erl index 5534abacd..09e270fbb 100644 --- a/apps/emqx_management/src/emqx_mgmt_data_backup.erl +++ b/apps/emqx_management/src/emqx_mgmt_data_backup.erl @@ -237,11 +237,11 @@ import_resources_and_rules(Resources, Rules, FromVersion) <<"url">> => URL, <<"verify">> => true}, NResource = Resource#{<<"config">> := NConfig}, - import_resource(NResource), + {ok, _Resource} = import_resource(NResource), NHeaders = maps:put(<<"content-type">>, ContentType, Headers), [{ID, #{headers => NHeaders, method => Method}} | Acc]; (Resource, Acc) -> - import_resource(Resource), + {ok, _Resource} = import_resource(Resource), Acc end, [], Resources), lists:foreach(fun(#{<<"actions">> := Actions} = Rule) -> diff --git a/apps/emqx_rule_engine/src/emqx_rule_registry.erl b/apps/emqx_rule_engine/src/emqx_rule_registry.erl index 3e4e4b74c..dc7a33805 100644 --- a/apps/emqx_rule_engine/src/emqx_rule_registry.erl +++ b/apps/emqx_rule_engine/src/emqx_rule_registry.erl @@ -407,8 +407,8 @@ delete_resource_type(Type) -> init([]) -> %% Enable stats timer ok = emqx_stats:update_interval(rule_registery_stats, fun update_stats/0), - ets:new(?KV_TAB, [named_table, set, public, {write_concurrency, true}, - {read_concurrency, true}]), + _TableId = ets:new(?KV_TAB, [named_table, set, public, {write_concurrency, true}, + {read_concurrency, true}]), {ok, #{}}. handle_call({add_rules, Rules}, _From, State) -> diff --git a/apps/emqx_web_hook/src/emqx_web_hook_app.erl b/apps/emqx_web_hook/src/emqx_web_hook_app.erl index d31df9b93..54ac9c317 100644 --- a/apps/emqx_web_hook/src/emqx_web_hook_app.erl +++ b/apps/emqx_web_hook/src/emqx_web_hook_app.erl @@ -30,7 +30,7 @@ start(_StartType, _StartArgs) -> translate_env(), {ok, Sup} = emqx_web_hook_sup:start_link(), {ok, PoolOpts} = application:get_env(?APP, pool_opts), - ehttpc_sup:start_pool(?APP, PoolOpts), + {ok, _Pid} = ehttpc_sup:start_pool(?APP, PoolOpts), emqx_web_hook:register_metrics(), emqx_web_hook:load(), {ok, Sup}. diff --git a/lib-ce/emqx_modules/src/emqx_modules_app.erl b/lib-ce/emqx_modules/src/emqx_modules_app.erl index ca735826c..a10176829 100644 --- a/lib-ce/emqx_modules/src/emqx_modules_app.erl +++ b/lib-ce/emqx_modules/src/emqx_modules_app.erl @@ -25,7 +25,7 @@ start(_Type, _Args) -> % the configs for emqx_modules is so far still in emqx application % Ensure it's loaded - application:load(emqx), + _ = application:load(emqx), {ok, Pid} = emqx_mod_sup:start_link(), ok = emqx_modules:load(), emqx_ctl:register_command(modules, {emqx_modules, cli}, []),