From 139da6d720d0f9941865ea936e2e577951e41bf6 Mon Sep 17 00:00:00 2001
From: Thales Macedo Garitezi <thalesmg@gmail.com>
Date: Tue, 19 Dec 2023 17:26:05 -0300
Subject: [PATCH] fix: don't double-write the transformed config; return a
 triplet in all cases

---
 .../src/schema/emqx_connector_schema.erl             | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/apps/emqx_connector/src/schema/emqx_connector_schema.erl b/apps/emqx_connector/src/schema/emqx_connector_schema.erl
index 74b92c165..b51be53ed 100644
--- a/apps/emqx_connector/src/schema/emqx_connector_schema.erl
+++ b/apps/emqx_connector/src/schema/emqx_connector_schema.erl
@@ -224,17 +224,11 @@ split_bridge_to_connector_and_action(
                                             ConnectorFieldNameBin,
                                             maps:get(ConnectorFieldNameBin, BridgeV1Conf)
                                         ),
-                                    NewToTransform0 = maps:put(
+                                    maps:put(
                                         ConnectorFieldNameBin,
                                         PrevFieldConfig,
                                         ToTransformSoFar
-                                    ),
-                                    NewToTransform1 = maps:put(
-                                        to_bin(ConnectorFieldName),
-                                        maps:get(to_bin(ConnectorFieldName), BridgeV1Conf),
-                                        NewToTransform0
-                                    ),
-                                    NewToTransform1;
+                                    );
                                 false ->
                                     ToTransformSoFar
                             end
@@ -269,7 +263,7 @@ split_bridge_to_connector_and_action(
                     transform_bridge_v1_config_to_action_config(
                         BridgeV1Conf, ConnectorName, ConnectorFields
                     ),
-                {ActionMap0, OrgActionType}
+                {ActionMap0, OrgActionType, action}
         end,
     {BridgeType, BridgeName, ActionMap, ActionType, ActionOrSource, ConnectorName, ConnectorMap,
         ConnectorType}.