yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: avoid dynamic call

This commit is contained in:
JimMoen 2023-09-22 09:29:15 +08:00
parent c9e0d4fc30
commit 13666fa9f9
No known key found for this signature in database
GPG Key ID: 87A520B4F76BA86D
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apps/emqx_dashboard_sso/src/emqx_dashboard_sso_api.erl
View File

@ -239,7 +239,7 @@ sp_saml_metadata(get, _Req) ->
undefined -> undefined ->
{404, ?BACKEND_NOT_FOUND, <<"Backend not found">>}; {404, ?BACKEND_NOT_FOUND, <<"Backend not found">>};
#{sp := SP} = _State -> #{sp := SP} = _State ->
SignedXml = SP:generate_metadata(), SignedXml = esaml_sp:generate_metadata(SP),
Metadata = xmerl:export([SignedXml], xmerl_xml), Metadata = xmerl:export([SignedXml], xmerl_xml),
{200, [{<<"Content-Type">>, <<"text/xml">>}], Metadata} {200, [{<<"Content-Type">>, <<"text/xml">>}], Metadata}
end. end.

2
apps/emqx_dashboard_sso/src/emqx_dashboard_sso_saml.erl
View File

@ -129,7 +129,7 @@ destroy(#{resource_id := ResourceId}) ->
ok. ok.
login(_Req, #{sp := SP, idp_meta := #esaml_idp_metadata{login_location = IDP}} = _State) -> login(_Req, #{sp := SP, idp_meta := #esaml_idp_metadata{login_location = IDP}} = _State) ->
SignedXml = SP:generate_authn_request(IDP), SignedXml = esaml_sp:generate_authn_request(IDP, SP),
Target = esaml_binding:encode_http_redirect(IDP, SignedXml, <<>>), Target = esaml_binding:encode_http_redirect(IDP, SignedXml, <<>>),
%% TODO: _Req acutally is HTTP request body, not fully request %% TODO: _Req acutally is HTTP request body, not fully request
RedirectFun = fun(Headers) -> RedirectFun = fun(Headers) ->