From 121084b2ff45e1d80755bc87a1c53f8e62a5ebb9 Mon Sep 17 00:00:00 2001 From: Kjell Winblad Date: Tue, 14 May 2024 12:24:30 +0200 Subject: [PATCH] fix(kafka trace): do not include query type in trace entry For Kafka that has its internal buffering the on_query_async callback is used both for sync and async queries (for sync queries the caller waits for a response directly after calling on_query_async). Therefore, before this commit, the trace included incorrect query type information. This has been fixed by removing the query type information from the trace. This should be okay since the query type is not essential information and can be derived from the configuration. Fixes: https://emqx.atlassian.net/browse/EMQX-12363 --- .../emqx_bridge_kafka/src/emqx_bridge_kafka_impl_producer.erl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/emqx_bridge_kafka/src/emqx_bridge_kafka_impl_producer.erl b/apps/emqx_bridge_kafka/src/emqx_bridge_kafka_impl_producer.erl index 16bca153a..70091e7c2 100644 --- a/apps/emqx_bridge_kafka/src/emqx_bridge_kafka_impl_producer.erl +++ b/apps/emqx_bridge_kafka/src/emqx_bridge_kafka_impl_producer.erl @@ -320,7 +320,7 @@ on_query( #{headers_config => KafkaHeaders, instance_id => InstId} ), emqx_trace:rendered_action_template(MessageTag, #{ - message => KafkaMessage, send_type => sync + message => KafkaMessage }), do_send_msg(sync, KafkaMessage, Producers, SyncTimeout) catch @@ -380,7 +380,7 @@ on_query_async( #{headers_config => KafkaHeaders, instance_id => InstId} ), emqx_trace:rendered_action_template(MessageTag, #{ - message => KafkaMessage, send_type => async + message => KafkaMessage }), do_send_msg(async, KafkaMessage, Producers, AsyncReplyFn) catch