fix(resource): make some logging of the resource manager more secure
This commit is contained in:
parent
9c15720fee
commit
0eea8438bf
|
@ -387,7 +387,7 @@ handle_event(EventType, EventData, State, Data) ->
|
||||||
event_type => EventType,
|
event_type => EventType,
|
||||||
event_data => EventData,
|
event_data => EventData,
|
||||||
state => State,
|
state => State,
|
||||||
data => Data
|
data => redact_data(Data)
|
||||||
}
|
}
|
||||||
),
|
),
|
||||||
keep_state_and_data.
|
keep_state_and_data.
|
||||||
|
@ -397,15 +397,15 @@ log_state_consistency(State, #data{status = State} = Data) ->
|
||||||
log_state_consistency(State, Data) ->
|
log_state_consistency(State, Data) ->
|
||||||
?tp(warning, "inconsistent_state", #{
|
?tp(warning, "inconsistent_state", #{
|
||||||
state => State,
|
state => State,
|
||||||
data => Data
|
data => redact_data(Data)
|
||||||
}).
|
}).
|
||||||
|
|
||||||
log_cache_consistency(Data, Data) ->
|
log_cache_consistency(Data, Data) ->
|
||||||
ok;
|
ok;
|
||||||
log_cache_consistency(DataCached, Data) ->
|
log_cache_consistency(DataCached, Data) ->
|
||||||
?tp(warning, "inconsistent_cache", #{
|
?tp(warning, "inconsistent_cache", #{
|
||||||
cache => DataCached,
|
cache => redact_data(DataCached),
|
||||||
data => Data
|
data => redact_data(Data)
|
||||||
}).
|
}).
|
||||||
|
|
||||||
%%------------------------------------------------------------------------------
|
%%------------------------------------------------------------------------------
|
||||||
|
@ -661,3 +661,9 @@ safe_call(ResId, Message, Timeout) ->
|
||||||
exit:{timeout, _} ->
|
exit:{timeout, _} ->
|
||||||
{error, timeout}
|
{error, timeout}
|
||||||
end.
|
end.
|
||||||
|
|
||||||
|
%% the config and state of a bridge often contains some sensitive data
|
||||||
|
%% we shouldn't expose them to logs
|
||||||
|
redact_data(Data) ->
|
||||||
|
Msg = <<"this data is redacted due to security reasons">>,
|
||||||
|
Data#data{config = Msg, state = Msg}.
|
||||||
|
|
Loading…
Reference in New Issue