diff --git a/apps/emqx_bridge_cassandra/src/emqx_bridge_cassandra_connector.erl b/apps/emqx_bridge_cassandra/src/emqx_bridge_cassandra_connector.erl index 98ba587e8..285825714 100644 --- a/apps/emqx_bridge_cassandra/src/emqx_bridge_cassandra_connector.erl +++ b/apps/emqx_bridge_cassandra/src/emqx_bridge_cassandra_connector.erl @@ -143,12 +143,12 @@ on_start( {error, Reason} end. -on_stop(InstId, #{pool_name := PoolName}) -> +on_stop(InstId, _State) -> ?SLOG(info, #{ msg => "stopping_cassandra_connector", connector => InstId }), - emqx_resource_pool:stop(PoolName). + emqx_resource_pool:stop(InstId). -type request() :: % emqx_bridge.erl diff --git a/apps/emqx_bridge_clickhouse/src/emqx_bridge_clickhouse_connector.erl b/apps/emqx_bridge_clickhouse/src/emqx_bridge_clickhouse_connector.erl index 5d975cca7..211e41174 100644 --- a/apps/emqx_bridge_clickhouse/src/emqx_bridge_clickhouse_connector.erl +++ b/apps/emqx_bridge_clickhouse/src/emqx_bridge_clickhouse_connector.erl @@ -274,12 +274,12 @@ connect(Options) -> -spec on_stop(resource_id(), resource_state()) -> term(). -on_stop(InstanceID, #{pool_name := PoolName}) -> +on_stop(InstanceID, _State) -> ?SLOG(info, #{ msg => "stopping clickouse connector", connector => InstanceID }), - emqx_resource_pool:stop(PoolName). + emqx_resource_pool:stop(InstanceID). %% ------------------------------------------------------------------- %% on_get_status emqx_resouce callback and related functions diff --git a/apps/emqx_bridge_dynamo/src/emqx_bridge_dynamo_connector.erl b/apps/emqx_bridge_dynamo/src/emqx_bridge_dynamo_connector.erl index 86e816c5d..0cc3f993b 100644 --- a/apps/emqx_bridge_dynamo/src/emqx_bridge_dynamo_connector.erl +++ b/apps/emqx_bridge_dynamo/src/emqx_bridge_dynamo_connector.erl @@ -111,12 +111,12 @@ on_start( Error end. -on_stop(InstanceId, #{pool_name := PoolName}) -> +on_stop(InstanceId, _State) -> ?SLOG(info, #{ msg => "stopping_dynamo_connector", connector => InstanceId }), - emqx_resource_pool:stop(PoolName). + emqx_resource_pool:stop(InstanceId). on_query(InstanceId, Query, State) -> do_query(InstanceId, Query, State). diff --git a/apps/emqx_bridge_opents/src/emqx_bridge_opents_connector.erl b/apps/emqx_bridge_opents/src/emqx_bridge_opents_connector.erl index e49f552e9..71184e872 100644 --- a/apps/emqx_bridge_opents/src/emqx_bridge_opents_connector.erl +++ b/apps/emqx_bridge_opents/src/emqx_bridge_opents_connector.erl @@ -89,12 +89,12 @@ on_start( Error end. -on_stop(InstanceId, #{pool_name := PoolName} = _State) -> +on_stop(InstanceId, _State) -> ?SLOG(info, #{ msg => "stopping_opents_connector", connector => InstanceId }), - emqx_resource_pool:stop(PoolName). + emqx_resource_pool:stop(InstanceId). on_query(InstanceId, Request, State) -> on_batch_query(InstanceId, [Request], State). diff --git a/apps/emqx_bridge_rabbitmq/src/emqx_bridge_rabbitmq_connector.erl b/apps/emqx_bridge_rabbitmq/src/emqx_bridge_rabbitmq_connector.erl index e8404ffd3..0dc73b5f6 100644 --- a/apps/emqx_bridge_rabbitmq/src/emqx_bridge_rabbitmq_connector.erl +++ b/apps/emqx_bridge_rabbitmq/src/emqx_bridge_rabbitmq_connector.erl @@ -261,12 +261,15 @@ on_start( -spec on_stop(resource_id(), resource_state()) -> term(). on_stop( ResourceID, - #{poolname := PoolName} = _State + _State ) -> ?SLOG(info, #{ msg => "stopping RabbitMQ connector", connector => ResourceID }), + stop_clients_and_pool(ResourceID). + +stop_clients_and_pool(PoolName) -> Workers = [Worker || {_WorkerName, Worker} <- ecpool:workers(PoolName)], Clients = [ begin diff --git a/apps/emqx_bridge_tdengine/src/emqx_bridge_tdengine_connector.erl b/apps/emqx_bridge_tdengine/src/emqx_bridge_tdengine_connector.erl index aed5e5e0a..8fd41443c 100644 --- a/apps/emqx_bridge_tdengine/src/emqx_bridge_tdengine_connector.erl +++ b/apps/emqx_bridge_tdengine/src/emqx_bridge_tdengine_connector.erl @@ -108,7 +108,6 @@ on_start( Prepares = parse_prepare_sql(Config), State = Prepares#{pool_name => InstanceId, query_opts => query_opts(Config)}, - ok = emqx_resource:allocate_resource(InstanceId, pool_name, InstanceId), case emqx_resource_pool:start(InstanceId, ?MODULE, Options) of ok -> {ok, State}; @@ -121,12 +120,7 @@ on_stop(InstanceId, _State) -> msg => "stopping_tdengine_connector", connector => InstanceId }), - case emqx_resource:get_allocated_resources(InstanceId) of - #{pool_name := PoolName} -> - emqx_resource_pool:stop(PoolName); - _ -> - ok - end. + emqx_resource_pool:stop(InstanceId). on_query(InstanceId, {query, SQL}, State) -> do_query(InstanceId, SQL, State); diff --git a/apps/emqx_connector/src/emqx_connector_http.erl b/apps/emqx_connector/src/emqx_connector_http.erl index 386414cd4..c44212cc3 100644 --- a/apps/emqx_connector/src/emqx_connector_http.erl +++ b/apps/emqx_connector/src/emqx_connector_http.erl @@ -219,7 +219,6 @@ on_start( base_path => BasePath, request => preprocess_request(maps:get(request, Config, undefined)) }, - ok = emqx_resource:allocate_resource(InstId, pool_name, InstId), case ehttpc_sup:start_pool(InstId, PoolOpts) of {ok, _} -> {ok, State}; {error, {already_started, _}} -> {ok, State}; @@ -231,12 +230,7 @@ on_stop(InstId, _State) -> msg => "stopping_http_connector", connector => InstId }), - case emqx_resource:get_allocated_resources(InstId) of - #{pool_name := PoolName} -> - ehttpc_sup:stop_pool(PoolName); - _ -> - ok - end. + ehttpc_sup:stop_pool(InstId). on_query(InstId, {send_message, Msg}, State) -> case maps:get(request, State, undefined) of diff --git a/apps/emqx_connector/src/emqx_connector_ldap.erl b/apps/emqx_connector/src/emqx_connector_ldap.erl index 6cf717c46..c8c134f55 100644 --- a/apps/emqx_connector/src/emqx_connector_ldap.erl +++ b/apps/emqx_connector/src/emqx_connector_ldap.erl @@ -97,7 +97,6 @@ on_start( {pool_size, PoolSize}, {auto_reconnect, ?AUTO_RECONNECT_INTERVAL} ], - ok = emqx_resource:allocate_resource(InstId, pool_name, InstId), case emqx_resource_pool:start(InstId, ?MODULE, Opts ++ SslOpts) of ok -> {ok, #{pool_name => InstId}}; {error, Reason} -> {error, Reason} @@ -108,12 +107,7 @@ on_stop(InstId, _State) -> msg => "stopping_ldap_connector", connector => InstId }), - case emqx_resource:get_allocated_resources(InstId) of - #{pool_name := PoolName} -> - emqx_resource_pool:stop(PoolName); - _ -> - ok - end. + emqx_resource_pool:stop(InstId). on_query(InstId, {search, Base, Filter, Attributes}, #{pool_name := PoolName} = State) -> Request = {Base, Filter, Attributes}, diff --git a/apps/emqx_connector/src/emqx_connector_mongo.erl b/apps/emqx_connector/src/emqx_connector_mongo.erl index 1a64a0132..3a79cdf63 100644 --- a/apps/emqx_connector/src/emqx_connector_mongo.erl +++ b/apps/emqx_connector/src/emqx_connector_mongo.erl @@ -183,7 +183,6 @@ on_start( {worker_options, init_worker_options(maps:to_list(NConfig), SslOpts)} ], Collection = maps:get(collection, Config, <<"mqtt">>), - ok = emqx_resource:allocate_resource(InstId, pool_name, InstId), case emqx_resource_pool:start(InstId, ?MODULE, Opts) of ok -> {ok, #{ @@ -200,12 +199,7 @@ on_stop(InstId, _State) -> msg => "stopping_mongodb_connector", connector => InstId }), - case emqx_resource:get_allocated_resources(InstId) of - #{pool_name := PoolName} -> - emqx_resource_pool:stop(PoolName); - _ -> - ok - end. + emqx_resource_pool:stop(InstId). on_query( InstId, diff --git a/apps/emqx_connector/src/emqx_connector_mysql.erl b/apps/emqx_connector/src/emqx_connector_mysql.erl index 1263524fc..25db669ce 100644 --- a/apps/emqx_connector/src/emqx_connector_mysql.erl +++ b/apps/emqx_connector/src/emqx_connector_mysql.erl @@ -124,7 +124,6 @@ on_start( ] ), State = parse_prepare_sql(Config), - ok = emqx_resource:allocate_resource(InstId, pool_name, InstId), case emqx_resource_pool:start(InstId, ?MODULE, Options ++ SslOpts) of ok -> {ok, init_prepare(State#{pool_name => InstId})}; @@ -146,12 +145,7 @@ on_stop(InstId, _State) -> msg => "stopping_mysql_connector", connector => InstId }), - case emqx_resource:get_allocated_resources(InstId) of - #{pool_name := PoolName} -> - emqx_resource_pool:stop(PoolName); - _ -> - ok - end. + emqx_resource_pool:stop(InstId). on_query(InstId, {TypeOrKey, SQLOrKey}, State) -> on_query(InstId, {TypeOrKey, SQLOrKey, [], default_timeout}, State); diff --git a/apps/emqx_connector/src/emqx_connector_pgsql.erl b/apps/emqx_connector/src/emqx_connector_pgsql.erl index a2c8df3d3..cbe95cb33 100644 --- a/apps/emqx_connector/src/emqx_connector_pgsql.erl +++ b/apps/emqx_connector/src/emqx_connector_pgsql.erl @@ -121,7 +121,6 @@ on_start( {pool_size, PoolSize} ], State = parse_prepare_sql(Config), - ok = emqx_resource:allocate_resource(InstId, pool_name, InstId), case emqx_resource_pool:start(InstId, ?MODULE, Options ++ SslOpts) of ok -> {ok, init_prepare(State#{pool_name => InstId, prepare_statement => #{}})}; @@ -138,12 +137,7 @@ on_stop(InstId, _State) -> msg => "stopping postgresql connector", connector => InstId }), - case emqx_resource:get_allocated_resources(InstId) of - #{pool_name := PoolName} -> - emqx_resource_pool:stop(PoolName); - _ -> - ok - end. + emqx_resource_pool:stop(InstId). on_query(InstId, {TypeOrKey, NameOrSQL}, State) -> on_query(InstId, {TypeOrKey, NameOrSQL, []}, State); diff --git a/changes/ce/feat-10895.en.md b/changes/ce/feat-10895.en.md deleted file mode 100644 index f990b2e46..000000000 --- a/changes/ce/feat-10895.en.md +++ /dev/null @@ -1,8 +0,0 @@ -Refactored some bridges to avoid leaking resources during crashes at creation, including: -- TDEngine -- WebHook -- LDAP -- MongoDB -- MySQL -- PostgreSQL -- Redis diff --git a/changes/ee/feat-10895.en.md b/changes/ee/feat-10895.en.md new file mode 100644 index 000000000..b8a5d4e0f --- /dev/null +++ b/changes/ee/feat-10895.en.md @@ -0,0 +1 @@ +Refactored most of the bridges to avoid resource leaks during crashes during creation.