From 0b44c1b75f4b4c2246d720947e2e0bc459f609a2 Mon Sep 17 00:00:00 2001
From: Gilbert <gilbertw@emqx.io>
Date: Fri, 26 Oct 2018 17:25:31 +0800
Subject: [PATCH] improve_test_cases

---
 Makefile                       |  2 +-
 test/emqx_connection_SUITE.erl | 47 ----------------------------------
 2 files changed, 1 insertion(+), 48 deletions(-)
 delete mode 100644 test/emqx_connection_SUITE.erl

diff --git a/Makefile b/Makefile
index 4fdaabe92..90a46b9cd 100644
--- a/Makefile
+++ b/Makefile
@@ -35,7 +35,7 @@ EUNIT_OPTS = verbose
 # CT_SUITES = emqx_frame
 ## emqx_trie emqx_router emqx_frame emqx_mqtt_compat
 
-CT_SUITES = emqx emqx_client emqx_zone emqx_banned emqx_connection emqx_session \
+CT_SUITES = emqx emqx_client emqx_zone emqx_banned emqx_session \
 			emqx_access emqx_broker emqx_cm emqx_frame emqx_guid emqx_inflight emqx_json \
 			emqx_keepalive emqx_lib emqx_metrics emqx_mod emqx_mod_sup emqx_mqtt_caps \
 			emqx_mqtt_props emqx_mqueue emqx_net emqx_pqueue emqx_router emqx_sm \
diff --git a/test/emqx_connection_SUITE.erl b/test/emqx_connection_SUITE.erl
deleted file mode 100644
index 716e771b5..000000000
--- a/test/emqx_connection_SUITE.erl
+++ /dev/null
@@ -1,47 +0,0 @@
-%% Copyright (c) 2018 EMQ Technologies Co., Ltd. All Rights Reserved.
-%%
-%% Licensed under the Apache License, Version 2.0 (the "License");
-%% you may not use this file except in compliance with the License.
-%% You may obtain a copy of the License at
-%%
-%%     http://www.apache.org/licenses/LICENSE-2.0
-%%
-%% Unless required by applicable law or agreed to in writing, software
-%% distributed under the License is distributed on an "AS IS" BASIS,
-%% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-%% See the License for the specific language governing permissions and
-%% limitations under the License.
-
--module(emqx_connection_SUITE).
-
--compile(export_all).
--compile(nowarn_export_all).
-
--include_lib("common_test/include/ct.hrl").
-
-all() -> 
-    [{group, connection}].
-
-groups() ->
-    [{connection, [sequence], [t_attrs]}].
-
-init_per_suite(Config) ->
-    emqx_ct_broker_helpers:run_setup_steps(),
-    Config.
-    
-end_per_suite(_Config) ->
-    emqx_ct_broker_helpers:run_teardown_steps().
-
-
-t_attrs(_) ->
-    {ok, C, _} = emqx_client:start_link([{host, "localhost"}, {client_id, <<"simpleClient">>}, {username, <<"plain">>}, {password, <<"plain">>}]),
-    [{<<"simpleClient">>, ConnPid}] = emqx_cm:lookup_connection(<<"simpleClient">>),
-    Attrs = emqx_connection:attrs(ConnPid),
-    <<"simpleClient">> = proplists:get_value(client_id, Attrs),
-    <<"plain">> = proplists:get_value(username, Attrs),
-    emqx_client:disconnect(C).
-
-%% t_stats() ->
-%%     {ok, C, _ } = emqx_client;
-%% t_stats() ->
-