From 0937c8163247e2940815b3fe47451348b0f5222b Mon Sep 17 00:00:00 2001
From: Zaiming Shi <zmstone@gmail.com>
Date: Fri, 22 Oct 2021 07:46:57 +0200
Subject: [PATCH] test: fix emqx_config_SUITE

---
 apps/emqx/test/emqx_config_SUITE.erl | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/apps/emqx/test/emqx_config_SUITE.erl b/apps/emqx/test/emqx_config_SUITE.erl
index 88585492b..6b3022cae 100644
--- a/apps/emqx/test/emqx_config_SUITE.erl
+++ b/apps/emqx/test/emqx_config_SUITE.erl
@@ -36,6 +36,7 @@ t_fill_default_values(_) ->
         <<"perf">> => #{},
         <<"route_batch_clean">> => false}
     },
+    WithDefaults = emqx_config:fill_defaults(Conf),
     ?assertMatch(#{<<"broker">> :=
       #{<<"enable_session_registry">> := true,
         <<"perf">> :=
@@ -45,6 +46,8 @@ t_fill_default_values(_) ->
         <<"session_locking_strategy">> := quorum,
         <<"shared_dispatch_ack_enabled">> := false,
         <<"shared_subscription_strategy">> := round_robin,
-        <<"sys_heartbeat_interval">> := "30s",
-        <<"sys_msg_interval">> := "1m"}},
-    emqx_config:fill_defaults(Conf)).
+        <<"sys_heartbeat_interval">> := <<"30s">>,
+        <<"sys_msg_interval">> := <<"1m">>}}, WithDefaults),
+    %% ensure JSON compatible
+    _ = emqx_json:encode(WithDefaults),
+    ok.