feat: make http connector report errors

apps/emqx_connector/src/emqx_connector_http.erl

@@ -384,14 +384,15 @@ on_query_async(
 
 on_get_status(_InstId, #{pool_name := PoolName, connect_timeout := Timeout} = State) ->
     case do_get_status(PoolName, Timeout) of
-        true ->
+        ok ->
-            connected;
+            {connected, State};
-        false ->
+        {error, Reason} ->
             ?SLOG(error, #{
                 msg => "http_connector_get_status_failed",
+                reason => Reason,
                 state => State
             }),
-            disconnected
+            {disconnected, State, Reason}
     end.
 
 do_get_status(PoolName, Timeout) ->
@@ -400,24 +401,28 @@ do_get_status(PoolName, Timeout) ->
         fun(Worker) ->
             case ehttpc:health_check(Worker, Timeout) of
                 ok ->
-                    true;
+                    ok;
-                {error, Reason} ->
+                {error, Reason} = Error ->
                     ?SLOG(error, #{
                         msg => "ehttpc_health_check_failed",
                         reason => Reason,
                         worker => Worker
                     }),
-                    false
+                    Error
             end
         end,
     try emqx_misc:pmap(DoPerWorker, Workers, Timeout) of
-        [_ | _] = Status ->
+        % we crash in case of non-empty lists since we don't know what to do in that case
-            lists:all(fun(St) -> St =:= true end, Status);
+        [_ | _] = Results ->
+            case [E || {error, _} = E <- Results] of
                 [] ->
-            false
+                    ok;
+                Errors ->
+                    hd(Errors)
+            end
     catch
         exit:timeout ->
-            false
+            {error, timeout}
     end.
 
 %%--------------------------------------------------------------------